Repository navigation
[0.4.x] libvisual-plugins: Make input plugin "portaudio" fall back to mono as needed (e.g. for macOS) - #279
Merged
Merged
Conversation
This was referenced Feb 13, 2023
kaixiong
reviewed
Feb 14, 2023
|
|
||
| typedef struct { | ||
| PaStream *stream; | ||
| unsigned count_channels; // 0 (unknown), 1 (mono) or 2 (stereo) |
Member
There was a problem hiding this comment.
Would it be better to name this channel_count and use unsigned int (instead of unsigned)?
Member
Author
There was a problem hiding this comment.
@kaixiong can do. unsigned on its own is unsigned int, it was not by accident. Done, pushed.
hartwork
force-pushed
the
0.4.x-portaudio-improve
branch
from
February 14, 2023 15:23
f31f80c to
4e7922c
Compare
kaixiong
approved these changes
Feb 14, 2023
.. with an "Invalid number of channels" error.
hartwork
force-pushed
the
0.4.x-portaudio-improve
branch
from
February 14, 2023 15:36
4e7922c to
ba33b0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.